Add pasting logic for spans in email editor #2492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardolsson
approved these changes
Jan 24, 2025
|
|
||
| static get pasteConfig() { | ||
| return { | ||
| tags: ['P', 'SPAN'], |
There was a problem hiding this comment.
I'm realizing now that this filter is probably the reason why we only got span-related events in onPaste(). I wonder if there is some sort of wildcard that we could use, but for now, this is good enough because I believe it will solve the bug!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR solves the bug where formatted text pasted into the email editor would be turned into inline variables.
Screenshots
copied
pasted
Changes
Notes to reviewer
paste some stuff! preferrably on iOS! bc I have Windows and who knows what weirdness Windows does when copying things!
Related issues
Resolves #2394